Skip to content

Change datasetOverride property merge to maintain object type information#549

Closed
jgoakley wants to merge 1 commit into
jtblin:mainfrom
jgoakley:master
Closed

Change datasetOverride property merge to maintain object type information#549
jgoakley wants to merge 1 commit into
jtblin:mainfrom
jgoakley:master

Conversation

@jgoakley
Copy link
Copy Markdown

Created an issue around this Pull Reqest:

#548

… to angular.extend to maintain object type information
@jtblin jtblin deleted the branch jtblin:main April 29, 2026 05:26
@jtblin jtblin closed this Apr 29, 2026
@jtblin jtblin reopened this Apr 29, 2026
@jtblin jtblin changed the base branch from master to main April 29, 2026 10:42
@jtblin
Copy link
Copy Markdown
Owner

jtblin commented Apr 29, 2026

Thank you for the PR. After review, we have decided to stick with angular.merge for dataset overrides as deep merging allows for more granular configuration of nested properties (like tooltips or scales) within the override object. Shallow extension would overwrite these nested objects entirely, which might break existing implementations.

@jtblin jtblin closed this Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants